Patch implementation of Const.unapply
#10583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure the extrators does not match classes. This should be done using reflection.
* Do not match `'{null}` to avoid accidental NPEs.
* Do not match `'{}` as there is no value to extract.
```diff
- case Const(null) =>
+ case '{null} =>
- case Const(()) =>
+ case '{} =>
```
We specialize use the old, faster, implemtation for `Unliftable` as there it it correct by construction of the available `Unliftable`s.
|
@liufengyun small correction, we also need to check for |
nicolasstucki
force-pushed
the
path-const-extractor
branch
from
6ba8110 to
941410d
Compare
liufengyun
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'{null}to avoid accidental NPEs.'{}as there is no value to extract.We specialize use the old, faster, implementation for
Unliftableas there it correct by the construction of the availableUnliftables. We only need to add a null check forStringUnliftable.